Skip to content

Remain header when get object with a 301 redirect #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kesin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remain header when get object with a 301 redirect #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions server/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,6 +423,21 @@ func (s *Server) fetch(w io.Writer, oid, url string, size int, header http.Heade
}

req.Header = header

// Github put the AuthInfo in url params, so there is no problem when redirect like 301
// But in some other case, AuthInfo send in Header, we need to remain Header when there is a redirect
s.client = &http.Client{
CheckRedirect: func(req *http.Request, via []*http.Request) error {
// remain default policy
if len(via) >= 10 {
return errors.New("stopped after 10 redirects")
}

// remain header
req.Header = header
return nil
}}

resp, err := s.client.Do(req)
if err != nil {
return err
Expand Down