chore(deps)(deps): bump github.com/go-chi/chi/v5 from 5.2.3 to 5.2.4 in /gearbox in the go-dependencies group - #1
Merged
github-actions[bot] merged 1 commit intoFeb 1, 2026
Conversation
Contributor
Author
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
dependabot
Bot
force-pushed
the
dependabot/go_modules/gearbox/go-dependencies-9ddf65995b
branch
from
February 1, 2026 09:15
b95ef45 to
6a908c1
Compare
Bumps the go-dependencies group in /gearbox with 1 update: [github.com/go-chi/chi/v5](https://github.com/go-chi/chi). Updates `github.com/go-chi/chi/v5` from 5.2.3 to 5.2.4 - [Release notes](https://github.com/go-chi/chi/releases) - [Changelog](https://github.com/go-chi/chi/blob/master/CHANGELOG.md) - [Commits](go-chi/chi@v5.2.3...v5.2.4) --- updated-dependencies: - dependency-name: github.com/go-chi/chi/v5 dependency-version: 5.2.4 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: go-dependencies ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/go_modules/gearbox/go-dependencies-9ddf65995b
branch
from
February 1, 2026 15:08
6a908c1 to
b8770f4
Compare
dependabot
Bot
deleted the
dependabot/go_modules/gearbox/go-dependencies-9ddf65995b
branch
February 1, 2026 15:08
sarg3nt
added a commit
that referenced
this pull request
May 14, 2026
- Lint: golangci-lint's `unused` check runs without the `dev` build tag, so the shared constants in dev_bypass.go were flagged. Delete the shared file and inline the two constants into dev_bypass_on.go where they are actually referenced. - Doc accuracy (Copilot #1, #2): the `-tags dev` flag is set by the `dev:` target in gearbox/Makefile via `air --build.cmd "$(DEV_BUILD_CMD)"`, not by `.air.toml` (which is gitignored per-developer). Update the package doc and four function/header comments in dev_bypass_on.go, and the corresponding section in gearbox/docs/development.md, to reference the Makefile and drop the broken `../.air.toml` link. - Security (Copilot #3): EnsureDevUserExists previously returned early if a `dev` row already existed, leaving its password_hash untouched. A developer who manually set a password on that row could then form- login as a `dev` admin, contradicting the "form-login can never authenticate as this user" claim. Always rewrite password_hash to the caller-supplied dummyPasswordHash, plus reset status and must_change_password back to the safe defaults, on every call. Other fields (role, names) are still preserved across runs. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
sarg3nt
added a commit
that referenced
this pull request
May 14, 2026
* feat(#83): dev-only loopback auto-login bypass Compiled in only when the binary is built with `-tags dev` (which the `make dev` target now passes via air's --build.cmd). When all three of these hold the request is auto-authenticated as the seeded `dev` user: 1. Build tag `dev` is set. 2. GEARBOX_DEV_AUTO_LOGIN=1 in the environment. 3. Post-RealIP RemoteAddr is a loopback IP. Production builds (`make build`) replace every entry point with a no-op stub via dev_bypass_off.go, so the bypass code, env-var check, loopback check, seed function, and banner are not present in release binaries at all. Verified: - dev binary contains GEARBOX_DEV_AUTO_LOGIN and seed/banner strings; prod binary contains only the tryDevBypass no-op stub symbol. - cookieless GET / -> 303 /haproxy (auto-login). - cookieless GET / with X-Forwarded-For: 1.2.3.4 -> 303 /login (chi.RealIP rewrites RemoteAddr, loopback check declines). The seeded `dev` user has the package-level dummyPasswordHash so the form-login path can never authenticate as it; only the loopback bypass can. The seed is itself build-tag-gated (users_dev.go) so prod doesn't even contain the seed function. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(#83): address Copilot review on #84 - Lint: golangci-lint's `unused` check runs without the `dev` build tag, so the shared constants in dev_bypass.go were flagged. Delete the shared file and inline the two constants into dev_bypass_on.go where they are actually referenced. - Doc accuracy (Copilot #1, #2): the `-tags dev` flag is set by the `dev:` target in gearbox/Makefile via `air --build.cmd "$(DEV_BUILD_CMD)"`, not by `.air.toml` (which is gitignored per-developer). Update the package doc and four function/header comments in dev_bypass_on.go, and the corresponding section in gearbox/docs/development.md, to reference the Makefile and drop the broken `../.air.toml` link. - Security (Copilot #3): EnsureDevUserExists previously returned early if a `dev` row already existed, leaving its password_hash untouched. A developer who manually set a password on that row could then form- login as a `dev` admin, contradicting the "form-login can never authenticate as this user" claim. Always rewrite password_hash to the caller-supplied dummyPasswordHash, plus reset status and must_change_password back to the safe defaults, on every call. Other fields (role, names) are still preserved across runs. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the go-dependencies group in /gearbox with 1 update: github.com/go-chi/chi/v5.
Updates
github.com/go-chi/chi/v5from 5.2.3 to 5.2.4Commits
6eb3588middleware: harden RedirectSlashes handler (#1044)de0d16eUpdate comment about min Go version (#1023)9fb4a15update reverseMethodMap in RegisterMethod (#1022)51c977cRefactor to use atomic type (#1019)563ab11Refactor graceful shutdown example (#994)a52c582Bump minimum Go and use new features (#1017)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions