feat: add HTTP keep-alive support to HAProxy backend configuration - #108
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds optional HTTP keep-alive support to the HAProxy backend configuration generated by gearbox-agent, controlled via a new Docker Compose label and propagated through the backend config model into the HAProxy config generator.
Changes:
- Add
HTTPKeepAlivetocompose.BackendConfigand parse it fromhaproxy.backend.http_keep_alive. - Emit
option http-keep-alivein generated HAProxy backend stanzas when enabled. - Extend generator/parser tests to cover the new flag.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| gearbox-agent/internal/framework/services/haproxy/generator.go | Emit option http-keep-alive for backends when the new flag is enabled. |
| gearbox-agent/internal/framework/services/haproxy/generator_test.go | Add test coverage for keep-alive directive generation. |
| gearbox-agent/internal/framework/services/compose/parser.go | Add HTTPKeepAlive field to backend config and parse it from compose labels. |
| gearbox-agent/internal/framework/services/compose/parser_test.go | Extend “all labels” test to include the keep-alive label and assertion. |
…test Address Copilot review findings on PR #108: - Only emit `option http-keep-alive` when backend.Mode == "http"; emitting it for tcp-mode backends produces an invalid stanza. - Drop BackendSSL from the keep-alive test (it was generating `verify` with an empty value, unrelated to keep-alive). Add a separate test asserting the directive is suppressed for tcp-mode backends. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.