Lighten validation on the Athelete ID field to enable numerical values (especially for copy and paste) #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pasted values could be ignored if not in the correct format which was a pain for users. This change just manually adds the 'A' if it doesn't exist to ensure a better user experience.
|
@hsouth95 is attempting to deploy a commit to the sargant's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Sorry I hadn't seen this - not been receiving GitHub emails for months, not sure why! A good idea, but this logic currently prepends "A" to anything you paste. I'm going to take a look at refactoring this whole app soon and will keep this in mind - all I've done the past couple of years is update the certificates on an annual basis, but I'll keep the MR open as a reminder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had an issue when using this form where I tried to paste in my athelete ID number and was just going to manually add the 'A' at the beginning. In order to fix this, I've side-stepped the validation and just manually prepended the 'A'.
An alternative approach is to move the validation to the
handleOpenProfileand show a custom warning for this field.