Skip to content

use action more conventionally - #2924

Merged
burnettk merged 3 commits into
mainfrom
use-action-more-conventionally
Jul 23, 2026
Merged

burnettk merged 3 commits into
mainfrom
use-action-more-conventionally

Conversation

@burnettk

Copy link
Copy Markdown
Contributor

No description provided.

@coderabbitai

coderabbitai Bot commented Jul 20, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 818386b4-1acd-443f-9bee-12edcb7d42c5

📥 Commits

Reviewing files that changed from the base of the PR and between 6b80835 and 3fe3946.

📒 Files selected for processing (1)
  • .github/workflows/build_docker_images.yml
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/build_docker_images.yml

📝 Walkthrough

Walkthrough

The Docker build workflow changes metadata tagging for main, branch, and version-tag events using conditional raw, date/SHA branch, and semver rules.

Changes

Docker image tagging

Layer / File(s) Summary
Update Docker metadata tag rules
.github/workflows/build_docker_images.yml
docker/metadata-action now generates main-latest for main, date-plus-short-SHA tags for branches, and semver tags for v* refs.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is too vague to clearly describe the metadata-action tag changes in this PR. Use a specific title like 'Adjust Docker image tags in build workflow'.
Description check ❓ Inconclusive No PR description was provided, so there is no meaningful summary to evaluate. Add a brief description explaining the workflow tag-generation changes.
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch use-action-more-conventionally

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/build_docker_images.yml:
- Line 109: Update the semver tag configuration in the Docker image metadata
step to preserve the release tag’s v prefix by using the raw tag pattern (or an
equivalent v-prefixed version pattern), while keeping the existing tag-only
enable condition unchanged.
- Line 110: Remove the explicit raw latest-tag rule from the metadata
configuration around the type=raw entry. Rely on docker/metadata-action’s
default flavor to emit latest for valid semver release tags, preventing
non-semver tags such as v-next from overwriting it.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d436bf02-21a6-4e25-8d07-ca0f894e8c1b

📥 Commits

Reviewing files that changed from the base of the PR and between ec1cb61 and 6b80835.

📒 Files selected for processing (1)
  • .github/workflows/build_docker_images.yml

Comment thread .github/workflows/build_docker_images.yml Outdated
Comment thread .github/workflows/build_docker_images.yml Outdated
@burnettk

Copy link
Copy Markdown
Contributor Author

@copilot how does this look?

Copilot AI commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

@copilot how does this look?

The changes look correct:

  1. type=raw,value=main-latest with an explicit enable condition is clearer than the previous type=ref,event=branch,branch=main,suffix=-latest — the intent is unambiguous.
  2. type=semver,pattern={{raw}} preserves the v prefix (e.g., v2.2.0 stays v2.2.0), which aligns with the container retention policy that protects v*-style tags.
  3. Removing the explicit latest rule is correct — docker/metadata-action with the default flavor: latest=auto already emits latest automatically for valid semver release tags, so the explicit type=raw,value=latest was redundant (and risky, since startsWith(github.ref, 'refs/tags/v') also matches non-semver tags like v-next).

The hot fix (switching from {{version}} to {{raw}}) was the right call — {{version}} strips the v prefix.

@burnettk
burnettk merged commit 84e96a0 into main Jul 23, 2026
6 checks passed
@burnettk
burnettk deleted the use-action-more-conventionally branch July 23, 2026 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants