refactor: migrate from fuzzy-matcher to nucleo-matcher #855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace fuzzy-matcher with nucleo-matcher for improved performance and better Unicode handling. While the current use case (filtering Kubernetes resources with RFC1123 names) doesn't show noticeable performance difference with ~67 resources, this change provides: - 6-10x faster matching for larger datasets - Better maintained library (used in Helix editor) - Future-proofing for growth Additionally, added comprehensive test suite for fuzzy matching: - Added 14 new test cases covering edge cases, Kubernetes resource name patterns, case sensitivity, and scoring behavior - Tests increased from 491 to 505 total - All tests pass with both fuzzy-matcher and nucleo-matcher, ensuring backward compatibility Technical changes: - Replaced fuzzy-matcher::SkimMatcherV2 with nucleo-matcher::Matcher - Updated matching logic to use Pattern::parse() and score() - Changed score type from i64 to u32 - Used sort_by_key with Reverse for cleaner sorting code 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates the fuzzy matching implementation from
fuzzy-matchertonucleo-matcheras suggested in #781.Changes
Library Migration
fuzzy-matcher→nucleo-matchernucleo-matcheris actively maintained and used in Helix editorComprehensive Test Coverage
fuzzy-matcherandnucleo-matcherTest Coverage Includes
Technical Details
fuzzy-matcher::SkimMatcherV2withnucleo-matcher::MatcherPattern::parse()andscore()i64tou32sort_by_keywithReversefor cleaner sortingTesting
All 505 tests pass, including:
Performance Impact
Current use case (~67 resources) shows no noticeable performance difference, but this change future-proofs for:
Related Issue
Related to #781
🤖 Generated with Claude Code