fix: add MaxLength field to jsonschema.Definition #1097
+13
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add MaxLength field to the Definition struct in the jsonschema package. This allows users to specify the maximum length constraint for string types when defining JSON schemas. Closes sashabaranov#1006 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]> Signed-off-by: majiayu000 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1097 +/- ##
==========================================
+ Coverage 99.59% 99.61% +0.02%
==========================================
Files 34 34
Lines 2209 1841 -368
==========================================
- Hits 2200 1834 -366
+ Misses 6 4 -2
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for the maxLength JSON Schema constraint by adding a MaxLength field to the jsonschema.Definition struct. This addresses issue #1006 and enables users to specify maximum string length constraints in their JSON schemas.
Changes:
- Added
MaxLengthinteger field tojsonschema.Definitionstruct with proper JSON marshaling support - Added test case to verify
MaxLengthfield serialization to JSON
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| jsonschema/json.go | Adds MaxLength field to Definition struct with appropriate JSON tag and documentation |
| jsonschema/json_test.go | Adds test case verifying MaxLength field correctly serializes to JSON with value 100 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1006
Changes
MaxLengthfield tojsonschema.Definitionstruct with JSON tagmaxLength