fix: failed: json: cannot unmarshal object into Go struct field #1098
+256
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation converted JSON Schema to jsonschema.Definition during unmarshal, which lost unsupported features like anyOf, oneOf, allOf, const, title, and other JSON Schema Draft 2020-12 features. This fix uses json.RawMessage to preserve the complete schema during round-trip (unmarshal/marshal), ensuring all JSON Schema features are maintained while still validating that the schema is a valid JSON object. Fixes sashabaranov#1019 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]> Signed-off-by: majiayu000 <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1098 +/- ##
==========================================
- Coverage 99.59% 99.51% -0.09%
==========================================
Files 34 34
Lines 2209 1842 -367
==========================================
- Hits 2200 1833 -367
+ Misses 6 5 -1
- Partials 3 4 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…JSON Add test cases to improve coverage for the schema validation logic: - Test invalid schemas (array, string, number, boolean) - Test valid schemas with leading whitespace (spaces, tabs, newlines) - Test null schema and missing schema field - Ensure proper error messages for invalid schemas This improves test coverage for the new validation code in ChatCompletionResponseFormatJSONSchema.UnmarshalJSON. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1019
Changes
json.RawMessageinstead ofjsonschema.Definitionto preserve all JSON Schema features during unmarshal🤖 Generated with Claude Code