Update from task f49c9bcd-4214-4c79-8478-c488d15796c4

[sasly2048]

No description provided.

[Copilot]

Pull request overview

This PR appears to formalize project hygiene around testing/CI/documentation and adds periodic runtime refresh behavior in the WPF UI.

Changes:

• Added new unit tests for CredentialVault, AmfiNavService, and KiteService, plus code coverage collection packages/config.
• Updated MainWindow to periodically check session validity and auto-refresh portfolio during market hours.
• Added/updated repository documentation and GitHub metadata (templates, security policy, CODEOWNERS, dependabot), and refreshed contributing/changelog content.

Reviewed changes

Copilot reviewed 19 out of 20 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
tests/KiteGlance.Tests/KiteServiceTests.cs	Adds KiteService/Holding-related tests (currently includes assertions that don’t match implementation).
tests/KiteGlance.Tests/KiteGlance.Tests.csproj	Adds coverlet packages and links more production service files into the test project.
tests/KiteGlance.Tests/CredentialVaultTests.cs	Adds DPAPI credential vault tests (currently not Linux-safe).
tests/KiteGlance.Tests/AmfiNavServiceTests.cs	Adds NAV parsing tests (currently mismatched to Parse’s “two ISINs per row” behavior).
src/KiteGlance/MainWindow.xaml.cs	Adds session-check and auto-refresh timers, plus cleanup on close.
docs/TESTING.md	Introduces a documented testing strategy and commands (including coverage).
docs/README.md	Adds docs index/TOC.
docs/ARCHITECTURE.md	Adds architecture overview and data flow notes.
CONTRIBUTING.md	Rewrites contributing guide and PR process checklist.
CODE_OF_CONDUCT.md	Adds Contributor Covenant CoC.
CHANGELOG.md	Restructures changelog format/content and adds link refs.
.gitignore	Replaces ignore patterns (currently includes Markdown code fences).
.github/workflows/build.yml	Runs tests with coverage collection and uploads test artifacts.
.github/SECURITY.md	Adds a security policy / disclosure process.
.github/PULL_REQUEST_TEMPLATE.md	Adds a PR template.
.github/ISSUE_TEMPLATE/feature_request.md	Adds feature request template.
.github/ISSUE_TEMPLATE/bug_report.md	Adds bug report template.
.github/FUNDING.yml	Updates funding configuration.
.github/dependabot.yml	Adds dependabot configuration for NuGet and GitHub Actions.
.github/CODEOWNERS	Adds CODEOWNERS entries for core areas.

Comments suppressed due to low confidence (6)

src/KiteGlance/MainWindow.xaml.cs:130

• Same async-dispatch issue in the auto-refresh timer: awaiting Dispatcher.InvokeAsync(async () => await RefreshAsync(...)) does not await the inner RefreshAsync task. This can lead to unobserved exceptions and overlapping refresh dispatches. Unwrap the invoked task (or use DispatcherTimer).

            _autoRefreshTimer = new System.Timers.Timer(autoRefreshInterval * 60_000)
            {
                AutoReset = true,
                Enabled = true
            };
            _autoRefreshTimer.Elapsed += async (_, _) =>
            {
                // Only auto-refresh during market hours and when not already showing an overlay
                if (MarketOpen() && Overlay.Visibility != Visibility.Visible)
                {
                    await Dispatcher.InvokeAsync(async () => await RefreshAsync(manual: false));
                }
            };

tests/KiteGlance.Tests/KiteServiceTests.cs:48

• Checksum_produces_valid_sha256_hex() computes a SHA256 and validates its format, but it never calls KiteService's Checksum helper, so it can't catch regressions in the production implementation. Use reflection to invoke the private Checksum method and assert it matches the expected hex.

    [Fact]
    public void Checksum_produces_valid_sha256_hex()
    {
        // Test the checksum helper via reflection or direct access if available
        // For now, verify the format is correct (64 hex chars for SHA256)
        var testData = "apikey" + "requesttoken" + "apisecret";
        var hash = System.Security.Cryptography.SHA256.HashData(System.Text.Encoding.UTF8.GetBytes(testData));
        var hex = Convert.ToHexString(hash).ToLowerInvariant();
        
        Assert.Equal(64, hex.Length);
        Assert.Matches("^[a-f0-9]{64}$", hex);
    }

tests/KiteGlance.Tests/KiteServiceTests.cs:65

• Priced_returns_avg_when_last_is_zero_and_awaiting_true() will fail: Holding.LastPrice is a plain property and is never rewritten to AvgPrice. The Priced logic that substitutes avg for last<=0 lives in KiteService.Priced(), so test that helper directly (via reflection) or assert Pnl/Current behavior when AwaitingPrice is true.

    [Fact]
    public void Priced_returns_avg_when_last_is_zero_and_awaiting_true()
    {
        // This tests the internal Priced logic through Holding class
        var holding = new Holding
        {
            Qty = 10m,
            AvgPrice = 100m,
            LastPrice = 0m,
            IsMutualFund = false,
            AwaitingPrice = true
        };

        Assert.Equal(100m, holding.LastPrice);
        Assert.Equal(1000m, holding.Invested);
    }

tests/KiteGlance.Tests/AmfiNavServiceTests.cs:59

• Parse_skips_invalid_rows() has the same mismatch: valid rows contribute up to two ISIN keys each, so the expected count/keys are incorrect for the current Parse behavior.

        var result = AmfiNavService.Parse(dataWithInvalidRows);

        Assert.Equal(2, result.Count);
        Assert.True(result.ContainsKey("INF846K01EW2"));
        Assert.True(result.ContainsKey("INF090I01LK7"));
    }

tests/KiteGlance.Tests/AmfiNavServiceTests.cs:72

• Parse_handles_na_nav_values() expects a single result, but the valid row contains both growth and reinvest ISINs, so Parse() will return two entries. Update the expected count and assert both ISIN keys for the valid row.

        var result = AmfiNavService.Parse(dataWithNaNav);

        Assert.Single(result);
        Assert.False(result.ContainsKey("INF846K01EW2"));
        Assert.Equal(123.45m, result["INF204K01BC3"]);
    }

tests/KiteGlance.Tests/AmfiNavServiceTests.cs:85

• Parse_handles_zero_nav_values() has the same issue as the N.A. test: the valid row should produce two ISIN keys (growth + reinvest). The current expected count/asserts are inconsistent with Parse().

        var result = AmfiNavService.Parse(dataWithZeroNav);

        Assert.Single(result);
        Assert.False(result.ContainsKey("INF846K01EW2"));
        Assert.Equal(123.45m, result["INF204K01BC3"]);
    }

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.