-
Notifications
You must be signed in to change notification settings - Fork 14
Detect dependency loops in module migrator #249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pamelalozano16
wants to merge
1
commit into
sass:main
Choose a base branch
from
pamelalozano16:fix#137
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,6 @@ | ||
## 2.0.4 | ||
* Detect dependency loops in module migrator fix. | ||
|
||
## 2.0.3 | ||
|
||
### Module Migrator | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
// Copyright 2023 Google LLC | ||
// | ||
// Use of this source code is governed by an MIT-style | ||
// license that can be found in the LICENSE file or at | ||
// https://opensource.org/licenses/MIT. | ||
|
||
/// A graph data structure to manage dependencies between URIs. | ||
/// | ||
/// This class allows adding, removing, and querying dependencies | ||
/// between source URIs and their imported paths. | ||
class DependencyGraph { | ||
final Map<Uri, Set<Uri>> _graph = {}; | ||
|
||
/// Adds a dependency relationship between source and importedPath. | ||
void add(Uri source, Uri importedPath) { | ||
_graph.putIfAbsent(source, () => {}).add(importedPath); | ||
} | ||
|
||
/// Removes a dependency relationship between source and importedPath. | ||
void remove(Uri source, Uri importedPath) { | ||
_graph[source]?.remove(importedPath); | ||
} | ||
|
||
/// Finds all dependencies of a given source. | ||
Set<Uri>? find(Uri source) { | ||
return _graph[source]; | ||
} | ||
|
||
/// Checks if a specific dependency exists. | ||
bool hasDependency(Uri source, Uri importedPath) { | ||
return _graph.containsKey(source) && _graph[source]!.contains(importedPath); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
<==> arguments | ||
--migrate-deps | ||
|
||
<==> input/entrypoint.scss | ||
$a: red; | ||
@import "ejemplo"; | ||
a { | ||
background: $b; | ||
} | ||
|
||
<==> input/_ejemplo.scss | ||
$b: blue; | ||
a { | ||
color: $a; | ||
} | ||
|
||
<==> error.txt | ||
Error: Dependency loop detected: entrypoint -> ejemplo. | ||
To resolve this issue, consider either of the following: | ||
1. Remove the import statement that causes the dependency loop. | ||
2. Declare the variables used in the other stylesheet within the same stylesheet. | ||
|
||
, | ||
2 | @import "ejemplo"; | ||
| ^^^^^^^^^ | ||
' | ||
entrypoint.scss 2:9 root stylesheet | ||
Migration failed! |
24 changes: 24 additions & 0 deletions
24
test/migrators/module/namespace_references/loop_error_one_reference.hrx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
<==> arguments | ||
--migrate-deps | ||
|
||
<==> input/entrypoint.scss | ||
$var1: 2; | ||
@import "library"; | ||
|
||
<==> input/_library.scss | ||
a { | ||
margin: $var1; | ||
} | ||
|
||
<==> error.txt | ||
Error: Dependency loop detected: entrypoint -> library. | ||
To resolve this issue, consider either of the following: | ||
1. Remove the import statement that causes the dependency loop. | ||
2. Declare the variables used in the other stylesheet within the same stylesheet. | ||
|
||
, | ||
2 | @import "library"; | ||
| ^^^^^^^^^ | ||
' | ||
entrypoint.scss 2:9 root stylesheet | ||
Migration failed! |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.