Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

[WIP] Timeout custom JS after 2000ms #1112

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

saper
Copy link
Member

@saper saper commented Aug 29, 2015

Do not wait for the JavaScript code
indefinitely - abort execution
attempt after 2000ms.

JavaScript code might never get called
if no loop events will be processed
(#1048)
or might block forever if there are
no more worker threads available
(#857).

Introduce one true way to print contents
of the SassValue union.
Set NODESASS_TRACE enviroment variable
to any value to get lots of output.
@wmertens
Copy link

Nice! I think 2s might be too short on slow systems though… how about 20s? It's not like this will be encountered often…

@saper
Copy link
Member Author

saper commented Feb 14, 2016

On Sun, 14 Feb 2016, Wout Mertens wrote:

Nice! I think 2s might be too short on slow systems though… how about 20s? It's not like this will be encountered often…

Feel free to change it as you wish. It's an experimental patch and it's kind of wrong, but it might
help to diagnose the problem (I doubt it will make compilation possible - it might only help to pinpoint
the offending include).

@xzyfer
Copy link
Contributor

xzyfer commented Mar 23, 2016

@saper what's the status of this?

@saper
Copy link
Member Author

saper commented Mar 25, 2016

This is just a workaround for people experiencing #1048 or #857, it still merges with the master. I'd leave it open here.

@saper saper force-pushed the master branch 2 times, most recently from 6c128d9 to 1e4bba8 Compare April 19, 2016 21:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants