This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
[WIP][RFC] Introduce JavaScript null value #1310
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever done() is called we should check for the sass.NULL value as well. While here, allow calling done(null) to anticipate removal of the sass.NULL one day. Fixes sass#1296
When the test fails, we are getting actual values in the error message instead of + true = false
If we implement sass.types.Null as an Object it gives a different error message.
|
I don't think that "null instanceof sass.types.Null" could be made true, I'd rather modify our test instead (not to depend on the implementation internals). |
|
I'm not convinced this is a good idea discussed briefly in #1088 (comment) I would hold off on this until we reach a consensus on #1320 |
saper
force-pushed
the
master
branch
2 times, most recently
from
6c128d9 to
1e4bba8
Compare
jiongle1
pushed a commit
to scantist-ossops-m2/node-sass
that referenced
this pull request
Apr 7, 2024
Clean up C++ namespaces
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe that having Sass.NULL (and Sass.TRUE,
Sass.FALSE) is incorrect. We should be using
real JavaScript primitives instead, if only
to avoid object identity issues, or to allow
natural constructs like:
I suggest assigning JavaScript 'null' to
sass.NULL and sass.types.Null.NULL names.
Current stage:
An attempt to instantiate sass.NULL object via:
gives a different error message now: