This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Expose Sass lang version via node-sass API and CLI #1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/extensions.js
Outdated
| @@ -279,6 +279,7 @@ function getVersionInfo(binding) { | |||
| return [ | |||
| ['node-sass', pkg.version, '(Wrapper)', '[JavaScript]'].join('\t'), | |||
| ['libsass ', binding.libsassVersion(), '(Sass Compiler)', '[C/C++]'].join('\t'), | |||
|
This will have to wait until |
|
Should we get this in for the next release? Think this test needs to be updated Line 1831 in 0c709c1 |
|
I'm not sure anyone will understand this but I have no objections. |
am11
force-pushed
the
master
branch
6 times, most recently
from
14a76d8 to
df6dd7b
Compare
|
Rebased and update the test file accordingly. |
API Usage:
```javascript
var sass = require('node-sass')
console.log(sass.info)
/*
node-sass 3.7.0 (Wrapper) [JavaScript]
libsass 3.3.6 (Sass Compiler) [C/C++]
Sass 3.4 (Sass Language) [Sass]
*/
```
CLI Usasge:
```sh
node-sass -v
node-sass 3.7.0 (Wrapper) [JavaScript]
libsass 3.3.6 (Sass Compiler) [C/C++]
Sass 3.4 (Sass Language) [Sass]
```
test/api.js
Outdated
| assert(info.indexOf('[JavaScript]') > 0); | ||
| assert(info.indexOf('[NA]') < 0); | ||
| assert(info.indexOf('(Sass Compiler)') > 0); | ||
| assert(info.indexOf('[C/C++]') > 0); | ||
| assert(info.indexOf('(Sass Language)') > 0); |
There was a problem hiding this comment.
I know this is the same as the others, but maybe we can fix up the message parameter at the same time. The current failure just says AssertionError: false == true, which doesn't really tell us anything 😉
|
@am11 I was under the impression sass/libsass@01f370a had been released. We will be shipping 3.3.7 soon. |
jiongle1
pushed a commit
to scantist-ossops-m2/node-sass
that referenced
this pull request
Apr 7, 2024
…n-interpolate Fix regression for interpolation adding additional escapes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API Usage:
CLI Usasge:
Related to sass/libsass#2021.
cc @chriseppstein