This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
[WIP] Make sure libsass headers are read first #2070
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case libsass is installed system-wide (e.g. the headers are in /usr/local/include) *and* node requires reading headers from the same path for the unbundled shared libraries like libuv, make sure -I/usr/local/include will not take precedence over our local bundles libsass headers.
nschonni
reviewed
Aug 18, 2017
| @@ -35,8 +35,9 @@ | |||
| 'GCC_ENABLE_CPP_EXCEPTIONS': 'NO', | |||
| 'MACOSX_DEPLOYMENT_TARGET': '10.7' | |||
| }, | |||
| 'include_dirs': [ | |||
| 'include_dirs+': [ | |||
There was a problem hiding this comment.
Could/should this be done below in the libsass_ext condition? Not too familar with the gyp syntax though
|
Yes. That is how it should be, but it does not work. Paths added from behind the condition will be merged in, but they get appended regardless of + We need this because I want to propose node-gyp change to use potentially systemwide paths for libuv and such. If an older libsass is installed globally old header files will be used instead of our new ones. |
|
@saper I just flipped this to Draft since it had "WIP" in the title. If it's good to go, feel free to flip it back |
jiongle1
pushed a commit
to scantist-ossops-m2/node-sass
that referenced
this pull request
Apr 7, 2024
Trailing commas in parameters and arguments was introduced in 3.5. Fixes sass#2070 Spec sass/sass-spec#1090
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case libsass is installed system-wide
(e.g. the headers are in /usr/local/include) and
node requires reading headers from the same path
for the unbundled shared libraries like libuv,
make sure -I/usr/local/include will not take
precedence over our local bundles libsass headers.