feat: R syntax highlighting and Notebook Support#1719

Open

Wizzzzzzard wants to merge 56 commits intosassoftware:mainfrom

Wizzzzzzard:feat/procrlang-enablement

Member

Wizzzzzzard commented Dec 4, 2025 •

edited

Loading

Summary:
This PR adds initial support for the R language (via PROC R), equivalent to the existing support for Python (PROC PYTHON) and Lua (PROC LUA).

Addresses #1572

Testing:

Lexer Tests: Verified PROC R code zones are properly detected (4 passing tests)
Client Tests: Verified R code wrapping and notebook cell handling (146 passing tests)
Formatter Tests: Verified R code preservation in formatter expected outputs
Manual Testing:
- Created R code cells in SAS Notebooks
- Exported notebooks to SAS and verified PROC R generation
- Exported notebooks to HTML and verified R syntax highlighting
- Tested formatter preserves R code formatting

TODOs:

Add R language support to lexer/parser
Add R support to SAS Notebooks (cells, export)
Add R syntax highlighting via embeddedLanguages
Add formatter preservation for R code blocks
Add test coverage (server and client)
Update documentation (README, website docs, CHANGELOG)
Verify backward compatibility with existing notebooks
Test all export formats (SAS, HTML)

Future Enhancements (Not in this PR):

R Language Server integration for IntelliSense (autocomplete, hover, diagnostics) - similar to Pyright for Python
- Note: This would be moderately complex to implement as most R language servers require the R runtime environment, making browser support challenging

Wizzzzzzard added 24 commits

December 4, 2025 16:59


          initial commit of proc_r embedded lang test

416922d


          adding R language options to client and notebook

74a5d31


          adding some R Code test fixtures


          fixing rlang testfixture file name

8f22394


          adding a print statement to debug rlang zonelist

97489e5


          updating debug function for zone_type assertions

696bddd


          DCO Remediation Commit for Elijah Cúchulainn Reid <56865341+Wizzzzzza…

a05b28f

…rd@users.noreply.github.com>

I, Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 416922d
I, Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 74a5d31
I, Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 0231587
I, Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 8f22394
I, Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 97489e5
I, Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 696bddd

Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>


          Updating Lexer to correctly parse PROC RLANG code

29dfd9a


          Adding PROC_RLANG to CodeZoneManager

0e2b746


          Adding R as an option to the parser for formatting

398c156


          DCO Remediation Commit for Elijah Cúchulainn Reid <56865341+Wizzzzzza…

ca52898

…rd@users.noreply.github.com>

I, Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 29dfd9a
I, Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 0e2b746
I, Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 398c156

Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>


          test with simpler rlang script

454a6ab


          resetting to more complex Rlang file

5e4da15

Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>


          fixing file

a3be20b

Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>


          adding more rlang tests to match pre-existing lua and python ones

412995f

Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>


          reverting embedded lang test assert for rlang

e62c8e8

DCO Remediation Commit for Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>

I, Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 454a6ab

Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>


          updating references to "rlang" as a language to "r" to work better wi…

c5f8f7f

…th VS Code's language server


          making spacing a bit nicer

d4da7ad

DCO Remediation Commit for Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>

I, Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>, hereby add my Signed-off-by to this commit: c5f8f7f

Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>


          tweaking R UID to see if it makes a difference

7e58b1c

Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>


          Updating notebook with correctly highlighted R code

925ff77

Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>


          uploading notebook with R output

9e1b66a

Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>


          making the rlang id match python

3b41802

Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>


          Updating references to languages in docs to include R

54f72e3

Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>


          Including R changes in the Changelog

82d5f26

Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>

Wizzzzzzard changed the title ~~initial commit of proc_r embedded lang test~~ feat: R syntax highlighting and Notebook Support

scottdover reviewed

View reviewed changes

Contributor

scottdover left a comment

Only a few minor comments

client/src/components/notebook/exporters/toSAS.ts Outdated Show resolved Hide resolved

client/src/components/notebook/exporters/toSAS.ts Outdated Show resolved Hide resolved

server/src/sas/CodeZoneManager.ts Outdated Show resolved Hide resolved

server/src/sas/Lexer.ts Outdated Show resolved Hide resolved

Wizzzzzzard added 3 commits

December 5, 2025 15:20


          removing rlang case now that references have been updated to r

ca092d2

Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>


          removing debug function from CodeZoneManager

adc239c

Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>


          Simplifying R comment/string regex in Lexer

18cba79

Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>

Wizzzzzzard marked this pull request as ready for review

December 5, 2025 15:45

Wizzzzzzard added 12 commits

December 22, 2025 18:31


          Merge branch 'main' into feat/procrlang-enablement

531f290


          fix: updating CHANGELOG

fa33745

Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>


          feat: cleaning up proc r formatting

fe5abc7

Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>


          feat: fixing typo in proc r

96c78ba

Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>


          Merge branch 'main' into feat/procrlang-enablement

5e82a88


          feat: undoing notebook autoformat

7e8468d

Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>


          refactor: adding webpack.config.js to .vscodeignore

5cd3ca4

Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>


          chore: updating .vscodeignore to exclude unused files

d956732

Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>


          Merge branch 'main' into feat/procrlang-enablement

04cffa8


          Merge branch 'main' into feat/procrlang-enablement

e4c3bac


          Merge branch 'main' into feat/procrlang-enablement

d8fb276


          Merge branch 'main' of personal:Wizzzzzzard/vscode-sas-extension into…

922e928

… feat/procrlang-enablement

scottdover reviewed

View reviewed changes

.vscodeignore Show resolved Hide resolved

CHANGELOG.md Outdated Show resolved Hide resolved

server/src/sas/formatter/parser.ts Show resolved Hide resolved

Wizzzzzzard added 3 commits

January 20, 2026 15:21


          Addressing feedback by updating CHANGELOG

Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>


          chore: Remove non-build artifacts from .vscodeignore

fe69604

Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>


          Merge branch 'main' into feat/procrlang-enablement

cf29fbc

Wizzzzzzard requested a review from scottdover

January 20, 2026 15:36

Wizzzzzzard added 6 commits

January 22, 2026 17:30


          Merge branch 'sassoftware:main' into feat/procrlang-enablement

94a3bea


          adding procedures json for R to allow correct syntax highlighting and…

598b064

… tooltips in the sas-lsp-server package

Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>


          adding R to list of procedures

32920df


          updating function for getting help tooltip to determine the proc rath…

655d905

…er than defaulting to python

DCO Remediation Commit for Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>

I, Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 32920df

Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>


          tweaking R.json to better reflect PYTHON.json

c0ae66c

Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>


          Fix ENDSUBMIT/ENDINTERACTIVE autocomplete to show correct docs based …

7d3feaa

…on procedure context

Previously, getCompleteItemHelp() hardcoded "PYTHON" when fetching documentation
for ENDSUBMIT and ENDINTERACTIVE keywords, causing incorrect PYTHON docs to display when these keywords were used in PROC R contexts.

Signed-off-by: Elijah Cúchulainn Reid <56865341+Wizzzzzzard@users.noreply.github.com>

scottdover approved these changes

View reviewed changes

Contributor

scottdover left a comment

I think this generally looks okay to me. @smorrisj, do you mind taking a look at this one too? My knowledge of this area of code is limited.


          Merge branch 'main' into feat/procrlang-enablement

dahils added testing testing-complete and removed verification-needed testing labels

dahils assigned Wizzzzzzard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing-complete