Merged
Conversation
scottdover
changed the title
scottdover
changed the title
scottdover
force-pushed
the
feat/916-where-filter
branch
from
da87547 to
8302df7
Compare
mikewporter
approved these changes
Feb 6, 2026
smorrisj
approved these changes
Feb 6, 2026
Contributor
|
LGTM. Scott and I chatted online for a bit. Recommend creating a separate issue to improve display of error messages in the component level. Not an issue specific to this PR, but would make for a better user experience to show better error messages coming from left hand side components. |
scottdover
force-pushed
the
feat/916-where-filter
branch
from
8302df7 to
ee6edbe
Compare
dahils
added
testing
added 7 commits
February 13, 2026 13:36
Signed-off-by: Scott Dover <Scott.Dover@sas.com>
Signed-off-by: Scott Dover <Scott.Dover@sas.com>
Signed-off-by: Scott Dover <Scott.Dover@sas.com>
Signed-off-by: Scott Dover <Scott.Dover@sas.com>
Signed-off-by: Scott Dover <Scott.Dover@sas.com>
Signed-off-by: Scott Dover <Scott.Dover@sas.com>
Signed-off-by: Scott Dover <Scott.Dover@sas.com>
scottdover
force-pushed
the
feat/916-where-filter
branch
from
ee6edbe to
3e03473
Compare
Signed-off-by: Scott Dover <Scott.Dover@sas.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This change adds a filter bar to the dataviewer and makes sure the data remains filtered
when switching between tabs.
Testing: