Skip to content

Chore: Update Gonzales-PE#1302

Open
TheJaredWilcurt wants to merge 2 commits into
sasstools:developfrom
TheJaredWilcurt:update-gonzales-pe
Open

Chore: Update Gonzales-PE#1302
TheJaredWilcurt wants to merge 2 commits into
sasstools:developfrom
TheJaredWilcurt:update-gonzales-pe

Conversation

@TheJaredWilcurt

@TheJaredWilcurt TheJaredWilcurt commented Apr 9, 2020

Copy link
Copy Markdown

What do the changes you have made achieve? Update the AST dep to resolve bugs.

Are there any new warning messages? no

Have you written tests? N/A

Have you included relevant documentation N/A

Which issues does this resolve? #1248

Might also resolve #877 and potentially others.

<DCO 1.1 Signed-off-by: TheJaredWilcurt TheJaredWilcurt@user.noreply.github.com>

@TheJaredWilcurt

Copy link
Copy Markdown
Author

This new Gonzales release was due to a security vulnerability fix. It also includes the "custom properties" fix. tonyganch/gonzales-pe#295 (comment)

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 97.532% when pulling a2b16e6 on TheJaredWilcurt:update-gonzales-pe into 52ccf2e on sasstools:develop.

@carlmendoza

Copy link
Copy Markdown

Hi, any update about when this fix will get merged?

Comment thread package.json
"glob": "^7.0.0",
"globule": "^1.0.0",
"gonzales-pe": "4.2.4",
"gonzales-pe": "4.3.0",

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DanPurdy I know you've stopped supporting this, but could you find some time in the next year to merge this and do a new release? it's a security fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[sass|scss] support css variables to property

3 participants