Skip to content

add dsb to SeuratWrappers#130

Open
MattPM wants to merge 4 commits into
satijalab:masterfrom
MattPM:master
Open

add dsb to SeuratWrappers#130
MattPM wants to merge 4 commits into
satijalab:masterfrom
MattPM:master

Conversation

@MattPM
Copy link
Copy Markdown

@MattPM MattPM commented Apr 28, 2022

dsb is an R package for normalizing ADT data.

manuscript: https://www.nature.com/articles/s41467-022-29356-8
CRAN: https://CRAN.R-project.org/package=dsb
github: https://github.com/niaid/dsb

We would like to add dsb to Seurat wrappers. Please let us know if we correctly added the link to the vignette build from CI in readme.md (see input to readme added below with the htmlpreview.github.io based html link. Let us know if anything else is required.

Thank you!

| dsb | Normalize and denoise ADT protein data using dsb with Seurat | Mulè et al., Nature Communications 2022 | https://CRAN.R-project.org/package=dsb |

Comment thread R/dsb.R Outdated
@MattPM
Copy link
Copy Markdown
Author

MattPM commented Jun 3, 2022

Thanks for your note @mojaveazure please see comment and latest commit.
Best,
-Matt

@MattPM
Copy link
Copy Markdown
Author

MattPM commented Aug 15, 2022

Hi @mojaveazure

I addressed your comment in the commit above 7564726. Functions from the package are now included.

Wanted to check in and see if you're waiting for anything else on my end?

Please let me know and thanks again.

@MattPM MattPM requested a review from mojaveazure January 17, 2023 18:38
@MattPM
Copy link
Copy Markdown
Author

MattPM commented Jan 17, 2023

Hello @mojaveazure
Please see comments above. I addressed your previous comment in the commit above. Functions from the package are now included.

Are you waiting for anything else on my end? Many thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants