fastTopics wrapper#151
Open
pcarbo wants to merge 55 commits into
Open
Conversation
… fixed the handling of the features (in particular, we avoid using VariableFeatures).
…oadings_fasttopics.
…er self contained.
Author
|
Hi Seurat Developers, The paper describing these methods is now published in Genome Biology. Please let me know if I should update the fastTopics wrapper code to address any new requirements or compatibility issues with the latest version of Seurat. Thank you! |
Author
|
Hi, now that Seurat 5 is released on CRAN, would now be a good time to revisit this pull request? Should I make sure that this wrapper is compatible with Seurat 5, and update it as needed? |
|
Just adding a +1 in support of Seurat5 support and +1 to Seurat Team in terms of merging into SeuratWrappers. @pcarbo in terms of updating to Seurat 5 it's pretty straightforward (from my brief testing). Only changes I had to make were:
Best, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Seurat Developers,
I'm submitting for your consideration a simple Seurat wrapper for the fastTopics package.
The most recent methods are described in a bioRxiv preprint.
I tried to follow the "contribution guide", but please let me know if you would like me to make any changes to the interface or implementation.
Thank you,
Peter