Updates to RunBanksy#214
Open
jleechung wants to merge 23 commits into
Open
Conversation
cyrillustan
approved these changes
Mar 6, 2026
cyrillustan
left a comment
cyrillustan
left a comment
There was a problem hiding this comment.
Running Seurat vignette took a long time, but a minimal reimplementation of the core change works.
Contributor
Author
|
hi @cyrillustan / seurat team! we’d like to merge some improvements to the BANKSY wrapper, but it looks like the CI is currently failing during package installation because the workflow environment has Seurat 4.0.1 installed, while SeuratWrappers now requires Seurat >= 5.0.0. do you know if there’s a workaround for this? thanks! |
Member
|
Hi @jleechung! Thank you for the PR & for the nudge. Updating the CI checks here is definitely something we need to work on but have yet to get to - we can ignore the failure at least for now. Will review/test & get back to you on this. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements:
BiocParallel.