feat: add new config property for storing raw json values#421
Open
RebeccaStevens wants to merge 4 commits into
Open
feat: add new config property for storing raw json values#421RebeccaStevens wants to merge 4 commits into
RebeccaStevens wants to merge 4 commits into
Conversation
github-project-automation
Bot
moved this to 🆕 New
in Mod Loader (SML), Alpakit, ExampleMod, and Engine
RebeccaStevens
force-pushed
the
bb-dev
branch
2 times, most recently
from
873428a to
c00db28
Compare
Each derived class of `URawFormatValue` now is responsible for the logic to convert itself to and from JSON. Use of the `FJsonRawFormatConverter` class is now deprecated.
… which they should deserialize For `URawFormatValue::FromJson` of values capable of having children, if the `UConfigProperty` is avaliable, that `UConfigProperty` is now used to perform the deserialize of the child value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've separated changes in to seperate commits that can be reviewed relatively independently.
In order for me to add this functionality, I had to refactor the existing ConfigProperty, RawFormatValue and Json Conversion logic a bit.
This change should not break any other mods, as I haven't removed any of the old implementations. I believe it is unlikely that many (if any) mods are interacting with these functions directly, and thus, no changes should even be noticed by mod developers.
In a future release, these old implementations should be able to be removed safely.
The new Raw ConfigProperty can not be set in Blueprints as it directly interacts with FJson values.