Prevent deleted mod version semver reuse#134
Merged
budak7273 merged 13 commits intoMay 24, 2026
Merged
Conversation
need to complete the test and confirm feature correctness through frontend
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/new-fields #134 +/- ##
===================================================
+ Coverage 41.77% 41.97% +0.20%
===================================================
Files 128 128
Lines 6159 6170 +11
===================================================
+ Hits 2573 2590 +17
+ Misses 3195 3185 -10
- Partials 391 395 +4 ☔ View full report in Codecov by Sentry. |
github-project-automation
Bot
moved this from 🏗 In progress
to ✅ Completed
in Rose Senior Project
budak7273
added a commit
to satisfactorymodding/smr-frontend
that referenced
this pull request
May 24, 2026
budak7273
added a commit
to satisfactorymodding/smr-frontend
that referenced
this pull request
May 24, 2026
budak7273
added a commit
to satisfactorymodding/smr-frontend
that referenced
this pull request
May 24, 2026
Vilsol
pushed a commit
that referenced
this pull request
May 25, 2026
* fixed bug added a check for duplicated versions when updating a mod * Update extract_mod_info.go * Update create_version_in_database.go * fixed lint issue * added smod file and test * *hopefully* feature working need to complete the test and confirm feature correctness through frontend * not really working(?) * refactor: `mise run format` * fix: tests should compile better * fix: tests should pass * chore: ran lint * refactor: simplify code and clarify error message * fix: update test expected error --------- Co-authored-by: rhit-zhangl8 <112708732+rhit-zhangl8@users.noreply.github.com> Co-authored-by: rhit-mooretj <112582846+rhit-mooretj@users.noreply.github.com>
Vilsol
pushed a commit
to satisfactorymodding/smr-frontend
that referenced
this pull request
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Reopening this for LiFu after #128 got closed by the branch being renamed)
added a check for duplicated versions when updating a mod