Skip to content

Modpack backend changes#136

Merged
budak7273 merged 23 commits into
feat/modpacksfrom
install-grid
Apr 28, 2026
Merged

Modpack backend changes#136
budak7273 merged 23 commits into
feat/modpacksfrom
install-grid

Conversation

@rhit-zhangl8

Copy link
Copy Markdown
Contributor

Added install grid calculation for Windows, Windows server, and Linux server, as well as tests.

@codecov

codecov Bot commented Apr 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 49.10180% with 170 lines in your changes missing coverage. Please review.
✅ Project coverage is 41.35%. Comparing base (25e7660) to head (eff5e1c).
⚠️ Report is 59 commits behind head on feat/modpacks.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
gql/resolver_modpacks.go 49.25% 124 Missing and 12 partials ⚠️
gql/directive.go 6.25% 15 Missing ⚠️
db/user.go 0.00% 13 Missing ⚠️
conversion/ent_to_graphql.go 79.31% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           feat/modpacks     #136      +/-   ##
=================================================
+ Coverage          41.18%   41.35%   +0.16%     
=================================================
  Files                135      113      -22     
  Lines               8274     8137     -137     
=================================================
- Hits                3408     3365      -43     
+ Misses              4422     4316     -106     
- Partials             444      456      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rhit-mooretj

Copy link
Copy Markdown
Contributor

Do we think this would make sense to run on creation of a modpack release to store the values? Modpacks have target fields right now that are unused, and I wonder if upon a call of "createmodpackrelease" the resolver calls this function instead of it being outward facing for the frontend to run this over and over again. If so, we should remove the targets field ever being required for a SQL call to clean it up before we implement it on the frontend. What do you think Rob?

The code itself looks good to me, so I have no issues with that just maybe a slight tweak on the usecase in practice.

@budak7273 budak7273 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review, haven't made it all the way through yet

Comment thread util/ratelimits.go Outdated
@budak7273 budak7273 changed the title Install grid Modpack backend changes Apr 14, 2026
@budak7273

Copy link
Copy Markdown
Member

Do we think this would make sense to run on creation of a modpack release to store the values? <...>

I think we discussed this on the discord, is the comment's question still relevant? Since modpack releases are immutable I think it makes sense to cache the target support on them yeah.

@rhit-mooretj

Copy link
Copy Markdown
Contributor

Do we think this would make sense to run on creation of a modpack release to store the values? <...>

I think we discussed this on the discord, is the comment's question still relevant? Since modpack releases are immutable I think it makes sense to cache the target support on them yeah.

This is no longer relevant. Each release stores targets that are calculated upon previewing a release, and also stored on modpack creation. The query to get targets is through GetModpacks, as you'll get info on the releases

@budak7273

Copy link
Copy Markdown
Member

Merging this now since it will get reviewed in #125's PR anyways so there are less things floating around

@budak7273 budak7273 merged commit 38c787d into feat/modpacks Apr 28, 2026
22 checks passed
@budak7273 budak7273 deleted the install-grid branch April 28, 2026 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants