fix(deps): update eslint version to fix peer dep conflict #207
Conversation
Any change to packages was previously causing issues due to conflicting peer dependencies. This updates to the recommended sveltekit eslint config and recent eslint versions
|
@joshuata is attempting to deploy a commit to the satisfactorymodding Team on Vercel. A member of the Team first needs to authorize it. |
Currently the repo requires commitlint to pass, but there is no notification until commit passes. This adds a prompt when commiting to help devs
There was a problem hiding this comment.
When trying to run this locally, I see new warnings that haven't been resolved. I'm not sure how your commit passed linting without triggering these warnings - are the new configs not pinned to a specific version of linter rules?
I tried to fix some of these warnings and commit, but it seems like these changes have also made all of my git clients error when trying to skip commit hooks. Not sure if this is a problem on my end or with the changes.
|
I left the warnings since I didn't want to make big changes based on a config change I wasn't sure would be accepted. We can absolutely fix them, I just wanted to be careful |
Any change to packages was previously causing issues due to conflicting peer dependencies. This updates to the recommended sveltekit eslint config and recent eslint versions