Skip to content

build: specify pnpm version in package.json and ci.yml#513

Merged
satnaing merged 3 commits into
satnaing:mainfrom
graycreate:patch-1
Jun 6, 2025
Merged

build: specify pnpm version in package.json and ci.yml#513
satnaing merged 3 commits into
satnaing:mainfrom
graycreate:patch-1

Conversation

@graycreate

Copy link
Copy Markdown
Contributor

Description

Specify a specific packageManager version in package.json, to fix the issue while deploying in cloudflare

Types of changes

Add packageManager to fix the build break in CloudFlare while deploying

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Documentation Update (if none of the other choices apply)
  • Others (any other types not listed above)

Checklist

  • I have read the Contributing Guide
  • I have added the necessary documentation (if appropriate)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)

Further comments

Related Issue

Closes: #

@satnaing

satnaing commented Jun 6, 2025

Copy link
Copy Markdown
Owner

@graycreate
Thanks for the solution.
However, we only update pnpm version in package.json, there's gonna be a package version mismatch in GitHub action.
I also updated the pnpm version in ci.yml to ensure it is in sync.

@satnaing satnaing changed the title Add packageManager to fix the build break in CloudFlare while deploying build: specify pnpm version in package.json and ci.yml Jun 6, 2025
@satnaing

satnaing commented Jun 6, 2025

Copy link
Copy Markdown
Owner

Turns out pnpm v10 should be working as expected without major problems.
Let me know if you encounter problems with pnpm v10. Maybe open a new issue.
For now, I'll merge this PR.

@satnaing
satnaing merged commit 5369626 into satnaing:main Jun 6, 2025
1 check passed
@eerison eerison mentioned this pull request Jun 7, 2025
@satnaing

Copy link
Copy Markdown
Owner

I've removed packageManager in the package.json in f57fd2b. (tempo commit)
I can deploy it on Cloudflare, and the build was successful.
Do you have any idea whether it's ok to deploy on Cloudflare without packageManager now? @graycreate

miyayaLora pushed a commit to miyayaLora/astro-paper-zed-like that referenced this pull request Jun 27, 2025
)

Specify pnpm version in both `package.json` and
`ci.yml` to avoid build errors during deployment.

---------
Closes satnaing#512
Co-authored-by: satnaing <satnaingdev@gmail.com>

(cherry picked from commit 5369626)
jxgla pushed a commit to jxgla/astro-paper that referenced this pull request Mar 10, 2026
)

Specify pnpm version in both `package.json` and
`ci.yml` to avoid build errors during deployment.

---------
Closes satnaing#512
Co-authored-by: satnaing <satnaingdev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants