fix: generateOgImageForSite error#568
Merged
Merged
Conversation
alec-c4
added a commit
to alec-c4/alec-c4.com
that referenced
this pull request
Aug 12, 2025
satnaing
approved these changes
Aug 21, 2025
Owner
|
BTW, |
Update code format for og.png.ts
Contributor
Author
Sure, I've pushed the new commit, sorry about code format issue |
jxgla
pushed a commit
to jxgla/astro-paper
that referenced
this pull request
Mar 10, 2026
…#568) Astro uses Web API typings; Response doesn’t accept Node Buffer. Convert the generated OG image Buffer to Uint8Array before constructing Response to satisfy BodyInit and fix the build/type error. Closes satnaing#560
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
generateOgImageForSite()/generateOgImageForPost()return a Buffer, but in TypeScript’s type definitions, new Response() does not accept Node.js Buffer—it only accepts Web platform BodyInit types (such as Blob, ArrayBuffer, Uint8Array, etc.).Astro uses Web API type definitions (dom lib) during build time, so Node.js Buffer types won’t match. Just simply convert the Buffer to a Uint8Array or ArrayBuffer to pass type checking.
Types of changes
Checklist
Further comments
Related Issue
It will fixed this issue
Closes: #560