fix: slugify supports better acronyms and preserve non-latin char #606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update slugify function to handle better acronyms and preserve non-latin characters. - uses slugify (simov) for Latin-only strings to fix acronym issue (eg: e2e-testing) - uses lodash.kebabcase for strings with non-latin characters to preserve them Fixes #584
Deploying astro-paper with
|
| Latest commit: |
6ad340c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://31560aab.astro-paper.pages.dev |
| Branch Preview URL: | https://fix-slugify-acronyms-and-non.astro-paper.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a hybrid slugify approach to fix the issue where acronyms like "E2E testing" were being converted to "e-2-e-testing" instead of "e2e-testing", while also preserving non-Latin characters in URLs.
Problem
The previous implementation used
lodash.kebabcasewhich:Solution
Implemented a hybrid approach that:
slugify(simov) with{ lower: true }for Latin-only strings (handles E2E correctly)lodash.kebabcasefor strings containing non-Latin characters (preserves them)Comparison of Solutions Tested
Testing
Tested with various inputs:
Types of changes
Checklist
Related Issue
Closes: #584