Skip to content

fix: iterate all weight matches in getFontPathByWeight #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
satnaing merged 2 commits into from
Jun 2, 2026
Merged

fix: iterate all weight matches in getFontPathByWeight #645

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8bdd93
fix: iterate all weight matches in getFontPathByWeight
cfresco-fb May 21, 2026
e9a0e1c
fix: add fallback to first src entry and trailing newline
cfresco-fb Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/utils/getFontPathByWeight.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,12 @@ export function getFontPathByWeight(
const style = options?.style ?? "normal";
const format = options?.format ?? "truetype";

return fonts
.find(font => font.weight === String(weight) && font.style === style)
?.src.find(file => file.format === format)?.url;
}
for (const font of fonts) {
if (font.weight === String(weight) && font.style === style) {
const src = font.src.find(file => file.format === format);
Comment thread
satnaing marked this conversation as resolved.
Outdated
if (src) return src.url;
}
}

return undefined;
}
Comment thread
satnaing marked this conversation as resolved.
Outdated
Loading