Fix build with modern GCC: suppress false-positive -Warray-bounds#21
Open
varun-r-mallya wants to merge 1 commit into
Open
Fix build with modern GCC: suppress false-positive -Warray-bounds#21varun-r-mallya wants to merge 1 commit into
varun-r-mallya wants to merge 1 commit into
Conversation
user_data[] is deliberately declared with a computed size that evaluates to 0 elements (it marks the start of a flash region sized by the linker, not by this C type), so indexing into it at runtime is intentional. Older GCC didn't flag this; GCC 12+ correctly notices the out-of-bounds access with -Warray-bounds, which -Werror then turns into a hard build failure. Scope the suppression to just this read so the build works with current arm-none-eabi-gcc without masking other array-bounds bugs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
user_data[] is declared with a size expression that computes to 0 elements, but the code intentionally indexes past that at runtime (it's really just a marker for a flash region sized by the linker, not by this C type). Older GCC allowed this; GCC 12+ correctly flags it with -Warray-bounds, which -Werror turns into a build failure. This suppresses the warning at that one read site so the build works on current toolchains.