Use Todoist's Sync API v9 and pass token as header#16
Open
goncalossilva wants to merge 2 commits intosaturn-abhishek:masterfrom
Open
Use Todoist's Sync API v9 and pass token as header#16goncalossilva wants to merge 2 commits intosaturn-abhishek:masterfrom
goncalossilva wants to merge 2 commits intosaturn-abhishek:masterfrom
Conversation
v8 was deprecated on December 5, 2022.
Passing tokens as query params will be deprecated soon.
Owner
|
@CodiumAI-Agent /review |
PR Reviewer Guide 🔍(Review updated until commit c0695a3)Here are some key observations to aid the review process:
|
Author
|
This PR will still work for now, but note that the Todoist API v1 has just been released which means Sync API v9 will be deprecated in the near future. Migration documentation is available here. It should still be a small change for this project: |
|
Persistent review updated to latest commit c0695a3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

v8 was deprecated on December 5, 2022, and passing tokens as query parameters will stop working soon.
I didn't notice any other incompatibility, but here's the migration guide from v8: https://developer.todoist.com/sync/v9/#migrating-from-v8