Improve sauce connect logging #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
budziam
force-pushed
the
mb/improve-logging
branch
2 times, most recently
from
7488126 to
c878a01
Compare
sb-sl
previously approved these changes
Feb 27, 2025
budziam
force-pushed
the
mb/improve-logging
branch
from
c878a01 to
328eab9
Compare
budziam
force-pushed
the
mb/improve-logging
branch
from
328eab9 to
c232d3f
Compare
sb-sl
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When investigating why the Sauce Connect health check fails, the logs do not provide enough data for effective debugging. This PR enhances logging to offer more information when the health check does not pass. Additionally, it improves customization of the TunnelManager behavior by allowing customization of SCMonitor and ProcessOutputPrinter.
Types of Changes
What types of changes does your code introduce? Keep the ones that apply: