encourate customers to debugging errors

Author: aga-szczepanska

Diff for: visual-js/visual-snapshots/src/app/pdf-handler.ts

@@ -12,11 +12,6 @@ export interface PdfCommandParams
   concurrency: number;
 }
 
-export enum PdfCommandStatus {
-  SUCCESS,
-  FAILURE,
-}
-
 export class PdfCommandHandler {
   constructor(
     private readonly visualSnapshotsApi: VisualSnapshotsApi,
@@ -26,13 +21,12 @@ export class PdfCommandHandler {
   public async handle(
     globsOrDirs: string[],
     params: PdfCommandParams
-  ): Promise<PdfCommandStatus> {
+  ): Promise<void> {
     const pdfFilePaths = await getFiles(globsOrDirs, "*.pdf");
 
     const buildId =
       params.buildId ?? (await this.visualSnapshotsApi.createBuild(params));
 
-    let status: PdfCommandStatus;
     try {
       await this.pdfSnapshotUploader.uploadSnapshots({
         buildId,
@@ -41,14 +35,10 @@ export class PdfCommandHandler {
         testNameFormat: params.testName,
         snapshotNameFormat: params.snapshotName,
       });
-      status = PdfCommandStatus.SUCCESS;
-    } catch (_) {
-      status = PdfCommandStatus.FAILURE;
-    }
-
-    if (!params.buildId) {
-      await this.visualSnapshotsApi.finishBuild(buildId);
+    } finally {
+      if (!params.buildId) {
+        await this.visualSnapshotsApi.finishBuild(buildId);
+      }
     }
-    return status;
   }
 }

Diff for: visual-js/visual-snapshots/src/commands/pdf.ts

@@ -12,11 +12,7 @@ import {
   suiteNameOption,
   usernameOption,
 } from "./options.js";
-import {
-  PdfCommandHandler,
-  PdfCommandParams,
-  PdfCommandStatus,
-} from "../app/pdf-handler.js";
+import { PdfCommandHandler, PdfCommandParams } from "../app/pdf-handler.js";
 import { EOL } from "os";
 import { VisualSnapshotsApi } from "../api/visual-snapshots-api.js";
 import { initializeVisualApi } from "../api/visual-client.js";
@@ -71,19 +67,11 @@ export const pdfCommand = (clientVersion: string) => {
 
       new PdfCommandHandler(visualSnapshotsApi, pdfSnapshotUploader)
         .handle(globsOrDirs, params)
-        .then((status: PdfCommandStatus) => {
-          if (status == PdfCommandStatus.SUCCESS) {
-            console.info("Successfully created PDF snapshots.");
-          } else {
-            console.error(
-              "At least one PDF snapshot creation failed. Please contact Sauce Labs customer support."
-            );
-          }
+        .then(() => {
+          console.info("Successfully created PDF snapshots.");
         })
         .catch((err) => {
-          console.error(
-            `An unexpected error occured when creating PDF snapshots: ${err}. Please contact Sauce Labs customer support.`
-          );
+          console.error(`At least one PDF snapshot creation failed: ${err}.`);
         });
     });
 };