Initial visual-snapshots package #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aga-szczepanska
force-pushed
the
feat/INT-16/pdf-snapshots
branch
2 times, most recently
from
b710ba4 to
eca98b9
Compare
aga-szczepanska
force-pushed
the
feat/INT-16/pdf-snapshots
branch
from
eca98b9 to
c49cd1b
Compare
aga-szczepanska
force-pushed
the
feat/INT-16/pdf-snapshots
branch
from
c49cd1b to
c5c8792
Compare
aga-szczepanska
changed the base branch from
main
to
feat/INT-1/pdf-snapshots
aga-szczepanska
changed the title
konraddysput
requested changes
Feb 18, 2025
perf2711
reviewed
Feb 18, 2025
aga-szczepanska
force-pushed
the
feat/INT-16/pdf-snapshots
branch
from
1a32cc4 to
5d9b92d
Compare
aga-szczepanska
force-pushed
the
feat/INT-16/pdf-snapshots
branch
from
5d9b92d to
6a0e504
Compare
aga-szczepanska
force-pushed
the
feat/INT-16/pdf-snapshots
branch
from
5d95c33 to
9f87866
Compare
perf2711
reviewed
Feb 19, 2025
| "version": "0.1.0", | ||
| "main": "lib/index.cjs", | ||
| "module": "lib/index.js", | ||
| "types": "lib/index.d.ts", |
There was a problem hiding this comment.
You're not emitting declaration files, so this can be removed.
There was a problem hiding this comment.
the types one or all 3 of them?
konraddysput
approved these changes
Feb 19, 2025
omacranger
reviewed
Feb 19, 2025
| return new Command() | ||
| .name("pdf") | ||
| .description("Create visual snapshots for each page of a PDF file") | ||
| .argument("<pdf-file-path>", "A path to a PDF file") |
There was a problem hiding this comment.
Out of scope of this MR so feel free to resolve upon reading, but noting for future -- should we be exposing this as a glob or something instead of a path to a single file to allow bulk snapshots?
There was a problem hiding this comment.
sounds like a really good idea!
There was a problem hiding this comment.
I don't know how to do that now... but hopefully it will become clearer when I start actually dealing with Visual. I will bear it in mind :)
omacranger
approved these changes
Feb 19, 2025
aga-szczepanska
added a commit
that referenced
this pull request
Mar 24, 2025
Generate visual-snapshots CLI package with pdf command which for now does nothing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate a new package called
visual-snapshotswithpdfcommand (which for now does nothing).