Skip to content

[INT-18] send pdf snapshots to Visual #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

aga-szczepanska
Copy link
Contributor

@aga-szczepanska aga-szczepanska commented Feb 20, 2025

Generate a snapshot for each page of a provided PDF file and send them to visual as a part of the same build (all parameters won't be properly handled yet)

@aga-szczepanska aga-szczepanska force-pushed the feat/INT-18/send-pdf-snapshots-to-visual branch from 601f4fb to 271ebc5 Compare February 21, 2025 19:17
@aga-szczepanska aga-szczepanska force-pushed the feat/INT-18/send-pdf-snapshots-to-visual branch from e1ee826 to 551fd6f Compare February 24, 2025 07:27
@aga-szczepanska aga-szczepanska marked this pull request as ready for review February 24, 2025 10:51
Copy link
Contributor

@paweltomaszewskisaucelabs paweltomaszewskisaucelabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will take a look more into it tomorrow.

Copy link
Contributor

@paweltomaszewskisaucelabs paweltomaszewskisaucelabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great progress! Keep in mind that you don't need to address everything in this MR. You can create new tickets for some tasks.

@aga-szczepanska aga-szczepanska force-pushed the feat/INT-18/send-pdf-snapshots-to-visual branch 4 times, most recently from aed2737 to a433f37 Compare February 25, 2025 11:57
@paweltomaszewskisaucelabs
Copy link
Contributor

Large file size thread

I'm more concerned about pdf convert library and visual storage usage.

@aga-szczepanska aga-szczepanska force-pushed the feat/INT-18/send-pdf-snapshots-to-visual branch from d63904d to b538c7d Compare February 26, 2025 15:07
@aga-szczepanska aga-szczepanska force-pushed the feat/INT-18/send-pdf-snapshots-to-visual branch from 16f3f84 to 1385f62 Compare February 27, 2025 15:17
@aga-szczepanska aga-szczepanska merged commit d8feea2 into feat/INT-1/pdf-snapshots Feb 27, 2025
1 check passed
@aga-szczepanska aga-szczepanska deleted the feat/INT-18/send-pdf-snapshots-to-visual branch February 27, 2025 15:44
aga-szczepanska added a commit that referenced this pull request Mar 24, 2025
- convert pdf file into images (one image per page)
- create a build
- create a snapshot for each pdf page image
- finish the build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants