Skip to content

Comments

[BIQ-763] add Option type with implicit get/set, remove JsonUndefined#257

Merged
perf2711 merged 1 commit intobugfix/BIQ-763/baseline-override-nullfrom
bugfix/BIQ-763/baseline-override-null--option
Jan 21, 2026
Merged

[BIQ-763] add Option type with implicit get/set, remove JsonUndefined#257
perf2711 merged 1 commit intobugfix/BIQ-763/baseline-override-nullfrom
bugfix/BIQ-763/baseline-override-null--option

Conversation

@perf2711
Copy link
Contributor

@perf2711 perf2711 commented Jan 21, 2026

add Option type with implicit get/set, remove JsonUndefined

Issue : BIQ-763

Description

A supplement to #256 which simplifies getters and setters in the BaselineOverride class.

Note: this change MAY result in breaking changes:

var override = new BaselineOverride {...};

// browser is now of type Option<string?>, which IS a breaking change
var testName = override.TestName;
// this WILL fail
testName.toLower();
// this WILL NOT fail, as implicit conversion is made
var equal = testName == "abc";

// this will also work fine
string? testName = override.TestName;
override.TestName = "abc";
new BaselineOverride 
{
  TestName = "abc",
  Browser = null,
}

Types of Changes

What types of changes does your code introduce? Keep the ones that apply:

  • Refactor/improvements

Testing strategy

  • run unit tests
  • run integration tests

@perf2711 perf2711 self-assigned this Jan 21, 2026
@perf2711 perf2711 added the enhancement New feature or request label Jan 21, 2026
@perf2711 perf2711 requested a review from omacranger January 21, 2026 09:45
@perf2711 perf2711 merged commit 535f372 into bugfix/BIQ-763/baseline-override-null Jan 21, 2026
2 checks passed
@perf2711 perf2711 deleted the bugfix/BIQ-763/baseline-override-null--option branch January 21, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants