chore: address all reviewer feedback from Jenkins hosting review#5
Merged
saurabh-oss merged 1 commit intomainfrom Apr 17, 2026
Merged
chore: address all reviewer feedback from Jenkins hosting review#5saurabh-oss merged 1 commit intomainfrom
saurabh-oss merged 1 commit intomainfrom
Conversation
pom.xml: - Add ban-deprecated-stapler.skip=false (new hosting checker requirement) - Update all URLs/SCM to jenkinsci/forgeai-pipeline-intelligence-plugin - Remove structs dependency (pulled in transitively) - Remove flexmark-all dependency (unused - report uses plain HTML strings) - Remove hpi.compatibleSinceVersion (only needed for breaking changes) - Remove entire <build> section (parent pom handles all defaults) config.jelly (ForgeAIGlobalConfiguration): - Remove fire emoji from section title - Remove custom styled <f:description> div - Switch temperature, timeout, maxTokens, criticalThreshold to f:number - Flatten nested f:section blocks so all entries belong visually to the same plugin section ForgeAIScanStep/config.jelly: - Add missing config.jelly so the step appears in the pipeline snippetizer Java: - DirectoryTreeCallable: implement ControllerToAgentFileCallable instead of deprecated MasterToSlaveFileCallable - LLMProvider: extend ExtensionPoint to allow third-party provider plugins - ForgeAIStep: use run.getParent().getFullName() and run.getNumber() instead of reading JOB_NAME/BUILD_NUMBER from env vars Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pom.xml:
config.jelly (ForgeAIGlobalConfiguration):
ForgeAIScanStep/config.jelly:
Java: