refactor: implement LLMProvider as proper Describable ExtensionPoint#6
Merged
saurabh-oss merged 1 commit intomainfrom Apr 17, 2026
Merged
refactor: implement LLMProvider as proper Describable ExtensionPoint#6saurabh-oss merged 1 commit intomainfrom
saurabh-oss merged 1 commit intomainfrom
Conversation
LLMProvider is now an abstract class implementing ExtensionPoint and Describable<LLMProvider>. Each provider has: - @DataBoundConstructor with sensible defaults (endpoint, modelId) - An @extension DescriptorImpl with getDisplayName() and doTestConnection() - Its own config.jelly rendered inline via f:hetero-radio Common fields (endpoint, modelId, apiKeyCredentialId) live in LLMProvider base. Common LLM call settings (temperature, timeout, maxTokens) remain in ForgeAIGlobalConfiguration and are read at call time — no duplication. ForgeAIGlobalConfiguration now stores a single LLMProvider instance selected via f:hetero-radio. Removed: providerType string, llmEndpoint, modelId, apiKeyCredentialId, doFillProviderTypeItems, resolveApiKey, doFillApiKeyCredentialIdItems (moved to LLMProviderDescriptor base class). LLMProviderFactory is kept as a deprecated pass-through for backward compatibility but is no longer the canonical way to obtain a provider. Third-party plugins can now add new LLM backends by extending LLMProvider and annotating their Descriptor with @extension — no changes required here. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLMProvider is now an abstract class implementing ExtensionPoint and Describable. Each provider has:
Common fields (endpoint, modelId, apiKeyCredentialId) live in LLMProvider base. Common LLM call settings (temperature, timeout, maxTokens) remain in ForgeAIGlobalConfiguration and are read at call time — no duplication.
ForgeAIGlobalConfiguration now stores a single LLMProvider instance selected via f:hetero-radio. Removed: providerType string, llmEndpoint, modelId, apiKeyCredentialId, doFillProviderTypeItems, resolveApiKey, doFillApiKeyCredentialIdItems (moved to LLMProviderDescriptor base class).
LLMProviderFactory is kept as a deprecated pass-through for backward compatibility but is no longer the canonical way to obtain a provider.
Third-party plugins can now add new LLM backends by extending LLMProvider and annotating their Descriptor with @extension — no changes required here.