Add unified method handlers for server-side - #5
Open
sauravzg wants to merge 1 commit into
Open
Conversation
This was referenced Jan 13, 2026
Owner
Author
|
This PR is part of a stack of 13 bookmarks:
Created with jj-stack |
This was referenced Jan 13, 2026
Open
Open
sauravzg
force-pushed
the
internal_method_handlers
branch
from
January 21, 2026 22:19
3079a2c to
f68df90
Compare
sauravzg
force-pushed
the
call_objects
branch
from
January 21, 2026 22:19
129a245 to
ab47c43
Compare
sauravzg
force-pushed
the
internal_method_handlers
branch
from
January 21, 2026 22:24
f68df90 to
be2c20d
Compare
sauravzg
force-pushed
the
internal_method_handlers
branch
from
February 24, 2026 16:53
be2c20d to
c9a9a2b
Compare
…r handling all types of gRPC methods on the server side, along with adapters for specific method types. Key changes: - Introduce `StreamingMethodHandler` trait to provide a common interface for method execution. - Add `UnaryMethodAdapter`, `ServerStreamingAdapter`, `ClientStreamingAdapter`, and `BidiStreamingAdapter` to bridge specific method traits to the unified handler. - This generic API has intentionally been kept private due to the pitfalls below. Known pitfalls: - Lazy and ResponseHolder are not very great abstractions to workaround the fact that we may not always have ownership of the underlying message. - Asymmetry between the API: Request is lazy while response is in a holder. - The API is very generic heavy, but this should be acceptable at least until we talk about interceptors. C++ has a similar setup with Generic handler until being type erased in the codec layer.
sauravzg
force-pushed
the
internal_method_handlers
branch
from
March 6, 2026 15:15
c9a9a2b to
1bdcc41
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.