Skip to content

Fix Mongolian ordinal IndexError on zero #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
patchwright wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Mongolian ordinal IndexError on zero #661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion num2words/lang_MN.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ def _get_ordinal_suffix(self, number):
if number_str[-1] != '0':
if number_str[-1] in ('1', '4', '9'):
suffix = 'дүгээр'
elif number_str[-2] != '0':
elif len(number_str) > 1 and number_str[-2] != '0':
if number_str[-2] in ('4', '9'):
suffix = 'дүгээр'
return suffix
Expand Down
16 changes: 16 additions & 0 deletions tests/test_mn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,15 @@ def test_to_ordinal(self):
"нэг мянга дугаар"
)

def test_to_ordinal_zero(self):
# ordinal(0) must not crash; base.verify_ordinal accepts 0 (English
# returns "zeroth") and Mongolian should honour the same contract,
# falling back to the default "дугаар" suffix.
self.assertEqual(
num2words(0, lang='mn', to='ordinal'),
"тэг дугаар"
)

def test_to_ordinal_num(self):
self.assertEqual(
num2words(105, lang='mn', to='ordinal_num'),
Expand All @@ -97,6 +106,13 @@ def test_to_ordinal_num(self):
"489 дүгээр"
)

def test_to_ordinal_num_zero(self):
# ordinal_num(0) must not crash; see test_to_ordinal_zero.
self.assertEqual(
num2words(0, lang='mn', to='ordinal_num'),
"0 дугаар"
)

def test_to_year(self):
self.assertEqual(
num2words(2005, lang='mn', to="year"),
Expand Down