fix: handle negative Vietnamese cardinals without corrupting words#674
Open
santhreal wants to merge 1 commit into
Open
fix: handle negative Vietnamese cardinals without corrupting words#674santhreal wants to merge 1 commit into
santhreal wants to merge 1 commit into
Conversation
Negative values indexed to_19 from the end (e.g. -1 became mười chín). Prefix with âm and convert the absolute value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lang_VI.number_to_text hits DataLoss/IndexError when negative int indexes to_19 from end producing wrong words or crash. This PR fixes the regression with a focused test covering the case.