Transfer: multiple source-target modes#460
Conversation
c268cb1 to
8c0c453
Compare
ValentinBoudevin
left a comment
There was a problem hiding this comment.
- "Copy assessments to other matching findings in one variant.¨ seems a bit difficult to understand as we don´t use findings anywhere else.
Should be something closer to "Copy assessments from previous packages versions in a variant".
Detected 0 assessments but this is wrong.
Example linux-yocto@6.6.129 (the current version) doesn´t have any custom assessments yet:
ValentinBoudevinSFL
left a comment
There was a problem hiding this comment.
The same-variant flow is generally well integrated, but overlapping source/target selections can corrupt copy results depending on operation order and must be addressed before merge.
| @@ -893,6 +894,7 @@ def copy_variant_assessments() -> ResponseReturnValue: | |||
| src_finding = assessment.finding | |||
There was a problem hiding this comment.
Within one variant, a selected target can also be the source assessment of another selection. In overwrite mode, processing A→B before B→A mutates B before its values are copied, making results order-dependent and potentially collapsing both assessments to A's values. Snapshot all source assessment fields before applying any writes, or reject cyclic/conflicting selections; add a reciprocal-copy test.
8c0c453 to
d4e2eda
Compare
Add a route selector for copying assessments within one variant or between two variants. Allow same-variant backend operations while excluding the source finding from preview and copy targets.
d4e2eda to
0444fe5
Compare
Fixes # by...
Changes proposed in this pull request:
Status
How to verify this change
Open the web dashboard, go to the Transfer tab then use the new "I want to copy…" selector
Pull Request Checklist
Please review and check all that apply before submitting your PR: