drivers: adc: shell: fix acquisition time printing#5
Draft
Surya-Tumma wants to merge 1 commit into
Draft
Conversation
| adc->resolution); | ||
|
|
||
| if (acq_time == ADC_ACQ_TIME_DEFAULT) { | ||
| shell_print(sh, "Acquisition Time: default"); |
Owner
There was a problem hiding this comment.
What does default mean here? It is supposed to tell the unit. correct?
Collaborator
Author
There was a problem hiding this comment.
ADC_ACQ_TIME_DEFAULT is nothing but zero default it will be zero.
Surya-Tumma
force-pushed
the
ADC_Shell_Fix
branch
from
99d353a to
09fd239
Compare
Collaborator
Author
|
Before and after Fix resullt: |
Fix cmd_adc_print to decode the raw packed acquisition_time bitfield into a human-readable value with units (us, ns, ticks) instead of printing a raw composite integer. Signed-off-by: Surya Prakash T <suryat@aerlync.com>
Surya-Tumma
force-pushed
the
ADC_Shell_Fix
branch
from
09fd239 to
f74daa1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix cmd_adc_print to decode the raw packed acquisition_time bitfield into a human-readable value with units (us, ns, ticks) instead of printing a raw composite integer.