Conversation
Mirror the runtime fixes applied to the upstream `homeassistant/components/echonet_lite` integration (drop assert-based properties on `_RuntimeController`, guarantee `protocol.close()` in the config-flow multicast probe, replace `del hass` with `# noqa: ARG001` in diagnostics, document the `byte_offset > 0` filter, remove redundant `_attr_has_entity_name` declarations on platform entities, refresh `quality_scale.yaml` comments). Also move the build-only generator out of the integration package so HACS users no longer receive dead code: - Remove `generate_strings.py` and `strings_static.json` (they only target the ha-core repo layout). - Rename `generator/` to a top-level `scripts/` directory. - Update `generate_ja.py` to absolute imports via a `sys.path` shim; invoke with `python scripts/generate_ja.py`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror the runtime fixes applied to the upstream
homeassistant/components/echonet_liteintegration (drop assert-based properties on_RuntimeController, guaranteeprotocol.close()in the config-flow multicast probe, replacedel hasswith# noqa: ARG001in diagnostics, document thebyte_offset > 0filter, remove redundant_attr_has_entity_namedeclarations on platform entities, refreshquality_scale.yamlcomments).Also move the build-only generator out of the integration package so HACS users no longer receive dead code:
generate_strings.pyandstrings_static.json(they only target the ha-core repo layout).generator/to a top-levelscripts/directory.generate_ja.pyto absolute imports via asys.pathshim; invoke withpython scripts/generate_ja.py.