Merged
Conversation
janfb
requested changes
Dec 19, 2024
Contributor
janfb
left a comment
There was a problem hiding this comment.
Thanks @manuel-morales-a! 🙏
The execution count indicates that you executed the notebooks cells multiple times, probably for testing. For merging this, it would be nice to have all cells executed in order from top to bottom.
Could you please restart the kernel and execute all cells from top? E.g., in VSCode, just click restart and then run all.
Contributor
Author
|
You're right! Cells have been properly executed now! Best, Manuel |
Contributor
|
Great, thanks! Ready to be merged then 🎉 |
janfb
approved these changes
Dec 23, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1336 +/- ##
===========================================
- Coverage 89.40% 78.65% -10.76%
===========================================
Files 118 118
Lines 8715 8722 +7
===========================================
- Hits 7792 6860 -932
- Misses 923 1862 +939
Flags with carried forward coverage won't be shown. Click here to find out more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes
This small PR fixes the random seed at the beginning of the SBC tutorial. In this way, the results that one obtains are reproducible and consistent with the text of the tutorial.
Does this close any currently open issues?
Fixes #1312.
Any relevant code examples, logs, error output, etc?
I have run the required linting and unit tests. The file I have changed does not present any errors (Maybe *.ipynb are not checked), but some other files do (to be addressed in a different issue/PR).
Any other comments?
N/a.
Checklist
Put an
xin the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.
guidelines
with
pytest.mark.slow.guidelines
mainbranchFor the reviewer: