Fix #1316: remove sample_dim docstring for condition.#1338
Merged
Conversation
janfb
force-pushed
the
fix-estimator-docstring
branch
from
fc3faa6 to
82185e7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1338 +/- ##
===========================================
- Coverage 89.40% 78.65% -10.76%
===========================================
Files 118 118
Lines 8715 8722 +7
===========================================
- Hits 7792 6860 -932
- Misses 923 1862 +939
Flags with carried forward coverage won't be shown. Click here to find out more.
|
manuelgloeckler
approved these changes
Dec 20, 2024
Contributor
manuelgloeckler
left a comment
manuelgloeckler
left a comment
There was a problem hiding this comment.
Look good. Just found the small typo (that hower already was there)
janfb
force-pushed
the
fix-estimator-docstring
branch
from
82185e7 to
c56056f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our current shape convention,
conditiondoes not have asample_dim, but the docstring was saying something else.fixes #1316