fix #1343 device handling in mog_log_prob#1356
Merged
Conversation
65fe33a to
f385ee5
Compare
manuelgloeckler
approved these changes
Jan 10, 2025
Contributor
manuelgloeckler
left a comment
There was a problem hiding this comment.
Looks good.
New tests also pass on my GPU.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1356 +/- ##
===========================================
- Coverage 89.40% 78.42% -10.99%
===========================================
Files 118 118
Lines 8715 8749 +34
===========================================
- Hits 7792 6861 -931
- Misses 923 1888 +965
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
constantfixes #1343