Skip to content

add nan handling in diagnostics#1359

Merged
janfb merged 2 commits intomainfrom
fix-sbc-nan-handling
Jan 13, 2025
Merged

add nan handling in diagnostics#1359
janfb merged 2 commits intomainfrom
fix-sbc-nan-handling

Conversation

@janfb
Copy link
Contributor

@janfb janfb commented Jan 10, 2025

fixes #1345 by adding nan and inf handling at the beginning of sbc, tarp and lc2st.

@codecov
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.44%. Comparing base (d3f22b5) to head (c97f37d).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
sbi/diagnostics/tarp.py 50.00% 1 Missing ⚠️
sbi/utils/diagnostics_utils.py 85.71% 1 Missing ⚠️
sbi/utils/sbiutils.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1359       +/-   ##
===========================================
- Coverage   89.40%   78.44%   -10.97%     
===========================================
  Files         118      118               
  Lines        8715     8779       +64     
===========================================
- Hits         7792     6887      -905     
- Misses        923     1892      +969     
Flag Coverage Δ
unittests 78.44% <78.57%> (-10.97%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sbi/diagnostics/lc2st.py 96.01% <100.00%> (+0.06%) ⬆️
sbi/diagnostics/sbc.py 95.77% <100.00%> (+0.06%) ⬆️
sbi/diagnostics/tarp.py 80.95% <50.00%> (-16.61%) ⬇️
sbi/utils/diagnostics_utils.py 97.36% <85.71%> (-2.64%) ⬇️
sbi/utils/sbiutils.py 78.11% <0.00%> (-8.68%) ⬇️

... and 30 files with indirect coverage changes

@janfb janfb requested a review from manuelgloeckler January 10, 2025 16:25
Copy link
Contributor

@manuelgloeckler manuelgloeckler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great :)

@janfb janfb force-pushed the fix-sbc-nan-handling branch from 66175ab to 7578027 Compare January 13, 2025 09:18
@janfb janfb force-pushed the fix-sbc-nan-handling branch from 7578027 to c97f37d Compare January 13, 2025 09:24
@janfb janfb merged commit 76c1e1b into main Jan 13, 2025
6 checks passed
@janfb janfb deleted the fix-sbc-nan-handling branch January 13, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

run_sbc and run_tarp seem to be failing with nan simulations

2 participants