Remove gate_activation to allow pickling#1694
Merged
michaeldeistler merged 1 commit intomainfrom Nov 6, 2025
Merged
Conversation
janfb
approved these changes
Nov 6, 2025
78847e5 to
3217e5e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1694 +/- ##
==========================================
- Coverage 88.48% 84.62% -3.86%
==========================================
Files 137 137
Lines 11473 11470 -3
==========================================
- Hits 10152 9707 -445
- Misses 1321 1763 +442
Flags with carried forward coverage won't be shown. Click here to find out more.
|
manuelgloeckler
approved these changes
Nov 6, 2025
Contributor
manuelgloeckler
left a comment
There was a problem hiding this comment.
Looks good, fine with that.
A slightly more general approach would be to replace the lambda with an function i.e. def default_gate_activation on a global namespace and then default to this. This should be pickable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1690
The
lambdain thegate_activationleads to a pickling error. We could work around this, but I think it is really a niche feature and I would simply remove the option to modify thegate_activation.