docs: redirect default ReadTheDocs root to stable version#1709
docs: redirect default ReadTheDocs root to stable version#1709Amitjoiya wants to merge 3 commits intosbi-dev:mainfrom
Conversation
|
Thanks for addressing this @Amitjoiya ! The redirect is certainly one solution. but could you please check whether there is a setting in the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1709 +/- ##
=======================================
Coverage ? 84.65%
=======================================
Files ? 137
Lines ? 11487
Branches ? 0
=======================================
Hits ? 9724
Misses ? 1763
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Hi @janfb , So the “Default version → stable” change can only be applied on the official SBI ReadTheDocs project, where the stable build exists. My PR adds the redirect as a fallback, but the actual fix requires switching: Happy to update/remove the redirect depending on what you prefer. |
|
yes, that's much better, please go ahead with this solution. |
|
@janfb , Good morning! If there’s anything else that needs refinement, I’d be happy to adjust it. |
|
Thanks for the changes and looking further into this. It seems we were too slow here and there was a settings-based solution that @michaeldeistler found and applied just now. Sorry about that, @Amitjoiya - Your initiative here is nevertheless much appreciated! You are welcome to have a look at another issue. Please comment below the issue you are interested in to first discuss how to solve it, before opening a PR - Thank you! |
Summary
This PR updates the ReadTheDocs configuration so that the default
documentation (
https://sbi.readthedocs.io/en/) redirects to the stableversion rather than latest, as requested in issue #1708.
Changes
.readthedocs.ymlto point/→/en/stable/.No other files were modified.