Skip to content

fix: add dependencies for tutorial tests; fix pymc errors.#1716

Merged
janfb merged 3 commits intomainfrom
fix-test-dependencies
Jan 7, 2026
Merged

fix: add dependencies for tutorial tests; fix pymc errors.#1716
janfb merged 3 commits intomainfrom
fix-test-dependencies

Conversation

@janfb
Copy link
Contributor

@janfb janfb commented Jan 5, 2026

We need the notebook dependencies during testing because we execute all notebooks during CI test.

  • add notebook dependency to test group via notebook group.

@janfb janfb requested a review from dgedon January 5, 2026 12:29
@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@8d47718). Learn more about missing BASE report.
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1716   +/-   ##
=======================================
  Coverage        ?   88.50%           
=======================================
  Files           ?      137           
  Lines           ?    11493           
  Branches        ?        0           
=======================================
  Hits            ?    10172           
  Misses          ?     1321           
  Partials        ?        0           
Flag Coverage Δ
unittests 88.50% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sbi/inference/posteriors/mcmc_posterior.py 84.05% <ø> (ø)
sbi/samplers/mcmc/pymc_wrapper.py 88.40% <100.00%> (ø)

@janfb
Copy link
Contributor Author

janfb commented Jan 5, 2026

CD is still failing, at least two problems:

  • we need the nbformat dep, not necessarily the full notebook dep
  • the z-scoring PR has introduced NaN issues in the slow tests

@janfb janfb force-pushed the fix-test-dependencies branch from ac097ac to 8975577 Compare January 6, 2026 15:06
- squeeze the energy output to fix the array vs scalar issue
- was partly fixed in #1697
@janfb janfb changed the title fix: add missing notebook test dependency fix: add dependencies for tutorial tests; fix pymc errors. Jan 7, 2026
@janfb
Copy link
Contributor Author

janfb commented Jan 7, 2026

CD was still failing with pymc errors for python versions >3.10 (see also #1697). This is now fixed (once and for all I hope) by squeezing the energy / likelihood output needed for NUTS / HMC before passing it to pymc.

@janfb
Copy link
Contributor Author

janfb commented Jan 7, 2026

Both CI and CD are passing now on all version, merging..

@janfb janfb merged commit 6e255ce into main Jan 7, 2026
13 checks passed
@janfb janfb deleted the fix-test-dependencies branch January 7, 2026 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants